fix PLE network bug & sort file list for ps trainer #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i是第几个task，需要乘上每个task的expert数量而不是task数量
liangzhenduo
changed the title
|
|
fixed code style
在不同节点上的文件顺序可能不一致，split_file_list可能读到相同的文件。sort以后保证每个节点的文件列表顺序一致，拆分读取个节点不会读到重复文件。
liangzhenduo
changed the title
|
更改reader是因为分布式训练时不同节点上的文件顺序可能不一致（都是无序状态），split_file_list后不同节点可能读到相同的文件。sort以后保证每个节点的文件列表顺序一致，拆分读取各节点不会读到重复文件。 |
|
pr 是正确的，同时 task_init 和 exp_init 的部分也有问题 |
dachr8
approved these changes
Sep 4, 2024
| for i in range(0, self.task_num): | ||
| for j in range(0, self.exp_per_task): | ||
| linear_out = self._param_expert[i * self.task_num + j]( | ||
| linear_out = self._param_expert[i * self.exp_per_task + j]( |
dachr8
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i表示第几个task，需要乘上每个task的expert数量，而不是乘task数量